RFR: JDK-8353319 : Open source Swing tests - Set 3 [v3]

Abhishek Kumar abhiscxk at openjdk.org
Thu Apr 17 19:14:46 UTC 2025


On Thu, 17 Apr 2025 00:19:19 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following tests are updates as part of this PR:
>> 
>> 1. javax/swing/JRootPane/bug4614623.java - manual
>> 2. javax/swing/JTabbedPane/bug4613811.java - manual
>> 3. javax/swing/JWindow/bug4251781.java - manual
>> 4. javax/swing/JFrame/bug4419914.java - manual, updated existing test by adding JWindow, JDialog cases.
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   test instruction updated for macOS

LGTM other than some minor observation.

test/jdk/javax/swing/JFrame/bug4419914.java line 89:

> 87:     public static void main(String[] args) throws Exception {
> 88:         PassFailJFrame.builder()
> 89:                 .title("Tab movement Instructions")

You may remove the title from all tests as it is redundant.

test/jdk/javax/swing/JWindow/bug4251781.java line 2:

> 1: /*
> 2:  * Copyright (c) 2000, 2024, Oracle and/or its affiliates. All rights reserved.

Suggestion:

 * Copyright (c) 2000, 2025, Oracle and/or its affiliates. All rights reserved.

-------------

Marked as reviewed by abhiscxk (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24639#pullrequestreview-2776683935
PR Review Comment: https://git.openjdk.org/jdk/pull/24639#discussion_r2049508545
PR Review Comment: https://git.openjdk.org/jdk/pull/24639#discussion_r2049507849


More information about the client-libs-dev mailing list