RFR: 8353446: Open source several AWT Menu tests - Batch 2

[Abhishek Kumar]

On Wed, 16 Apr 2025 10:28:26 GMT, Tejesh R <tr at openjdk.org> wrote:

> Open source these AWT Menu tests:
> 
> java/awt/Menu/OnFlyRepaintMenuTest/OnFlyRepaintMenuTest.java
> java/awt/Menu/DestroyMenuTest/DestroyMenuTest.java
> java/awt/Menu/MenuAddRemoveCrash/MenuAddRemoveCrash.java
> java/awt/Menu/MenuZOrderTest/MenuZOrderTest.java

test/jdk/java/awt/Menu/DestroyMenuTest/DestroyMenuTest.java line 47:

> 45:     public static void main(String[] args) throws Exception {
> 46:         String INSTRUCTIONS = """
> 47:                 1. Create many windows by randomly clicking 'Show Menu Test 1,

Suggestion:

                1. Create many windows by randomly clicking 'Show Menu Test 1',

test/jdk/java/awt/Menu/DestroyMenuTest/DestroyMenuTest.java line 57:

> 55:                       """;
> 56:         PassFailJFrame.builder()
> 57:                 .title("Test Instructions")

Setting title is redundant. You can remove in all the tests

test/jdk/java/awt/Menu/DestroyMenuTest/DestroyMenuTest.java line 133:

> 131: 
> 132:     static class mySimpleCanvas extends Canvas {
> 133:         public void paint(Graphics g) {

Please add @Override for overridden methods

test/jdk/java/awt/Menu/DestroyMenuTest/MenuTest.java line 153:

> 151: 
> 152: class MyRectCanvas extends Canvas {
> 153:     public void paint(Graphics g) {

Add @Override

test/jdk/java/awt/Menu/DestroyMenuTest/MenuTest.java line 165:

> 163: 
> 164: class MycircleCanvas extends Canvas {
> 165:     public void paint(Graphics g) {

same here

test/jdk/java/awt/Menu/MenuAddRemoveCrash.java line 63:

> 61:                 }
> 62:             }
> 63:         };

Can it be move to EventQueue.invokeAndWait ?

test/jdk/java/awt/Menu/MenuZOrderTest.java line 27:

> 25:  * @test
> 26:  * @bug 6267182
> 27:  * @summary Menu is not visible after showing and disposing a file dialog, XToolkit

XToolkit ?

test/jdk/java/awt/Menu/MenuZOrderTest.java line 43:

> 41: public class MenuZOrderTest {
> 42:     static class Listener implements ActionListener {
> 43:         public void actionPerformed(ActionEvent e) {

Add Override

test/jdk/java/awt/Menu/MenuZOrderTest.java line 54:

> 52:                 1. Choose Menu 1 --> Menu Item 1 several times.
> 53:                 2. If menu window is shown correctly and each click
> 54:                    creates new frame - press PASS.",

Suggestion:

                   creates new frame - press PASS.

test/jdk/java/awt/Menu/OnFlyRepaintMenuTest.java line 69:

> 67:         MenuItem menuItem;
> 68:         MenuItem submenuItem;
> 69:         CheckboxMenuItem checkMenuItem;

Can be removed and declared where it is initializing

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24681#discussion_r2050295047
PR Review Comment: https://git.openjdk.org/jdk/pull/24681#discussion_r2050295834
PR Review Comment: https://git.openjdk.org/jdk/pull/24681#discussion_r2050298386
PR Review Comment: https://git.openjdk.org/jdk/pull/24681#discussion_r2050300187
PR Review Comment: https://git.openjdk.org/jdk/pull/24681#discussion_r2050300430
PR Review Comment: https://git.openjdk.org/jdk/pull/24681#discussion_r2050303202
PR Review Comment: https://git.openjdk.org/jdk/pull/24681#discussion_r2050307568
PR Review Comment: https://git.openjdk.org/jdk/pull/24681#discussion_r2050307835
PR Review Comment: https://git.openjdk.org/jdk/pull/24681#discussion_r2050308706
PR Review Comment: https://git.openjdk.org/jdk/pull/24681#discussion_r2050310915