RFR: 8353552: Opensource Several Font related tests - Batch 3 [v2]

[Alexey Ivanov]

On Thu, 17 Apr 2025 19:18:18 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Few more font related tests are converted from applet and open-sourced.
>> 
>> TestGlyphVectorLayout.java doesn't behave as per the instruction and hence problem-listed under [JDK-8354987](https://bugs.openjdk.org/browse/JDK-8354987).
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Problem list test moved to manual test category

Changes requested by aivanov (Reviewer).

test/jdk/ProblemList.txt line 796:

> 794: java/awt/print/PrinterJob/ScaledText/ScaledText.java 8231226 macosx-all
> 795: java/awt/print/PrinterJob/PrintTextTest.java 8148334 macosx-all
> 796: java/awt/font/GlyphVector/TestGlyphVectorLayout.java 8354987 generic-all

Probably, you want to add [JDK-8355048](https://bugs.openjdk.org/browse/JDK-8355048) to the list of resolved issues, since you include problem-listing in this changeset, which makes perfect sense.

test/jdk/java/awt/font/TestGraphicPlacement.java line 166:

> 164:                     attribute,
> 165:                     i + name.length(),
> 166:                     i + name.length() + 1);

Suggestion:

            as.addAttribute(TextAttribute.CHAR_REPLACEMENT,
                            attribute,
                            i + name.length(),
                            i + name.length() + 1);

Align the wrapped parameters to match the style in lines 158–160 above?

-------------

PR Review: https://git.openjdk.org/jdk/pull/24736#pullrequestreview-2779172845
PR Review Comment: https://git.openjdk.org/jdk/pull/24736#discussion_r2050966012
PR Review Comment: https://git.openjdk.org/jdk/pull/24736#discussion_r2050970157