Removing obsolete Aqua code

[Kevin Rushforth]

Hi Jeremy,

I can see your bug submission, and have pinged the triage team to help 
move it along.

You can create a Draft PR without a bug ID, if you like, but you will 
need a bug ID before it can be "rfr".

-- Kevin


On 4/21/2025 12:43 AM, Jeremy Wood wrote:
> Thanks.
>
> I have a branch 
> <https://github.com/openjdk/jdk/compare/master...mickleness:JDK-8344697?expand=1> 
> for this work that is ready for feedback, but I assume I shouldn’t 
> make a PR until I have a new ticket number to use.
>
> I submitted a new OpenJDK ticket a week or so ago. Hopefully after 
> couple of weeks I’ll see it in the ticket database.
>
>  - Jeremy
>
> ------ Original Message ------
> From "Philip Race" <philip.race at oracle.com>
> To "Jeremy Wood" <mickleness at gmail.com>; "client-libs-dev at openjdk.org" 
> <client-libs-dev at openjdk.org>
> Date 4/11/2025 1:41:33 PM
> Subject Re: Removing obsolete Aqua code
>
>> https://bugs.openjdk.org/browse/JDK-8344697 is closed as a dup.
>> At this point I'd say A, although re-opening and renaming is possible.
>>
>> -phil
>>
>>
>> On 4/11/25 9:58 AM, Jeremy Wood wrote:
>>> in https://bugs.openjdk.org/browse/JDK-8344697 I pointed out that in 
>>> Mac's Aqua L&F: we’re using AncestorListeners to help repaint 
>>> JRootPane default buttons.
>>>
>>> Over a decade ago this logic was needed to emulate the native Aqua 
>>> experience, but since around 2016 the default button in Aqua does 
>>> NOT continually pulse.
>>>
>>> I’d like to remove this code, but I’m not sure how to proceed.
>>>
>>> Originally I planned to make a PR for 8344697 
>>> <https://bugs.openjdk.org/browse/JDK-8344697> that removes the 
>>> unused code. But after rebalancing the AWTEventMulticaster (in 
>>> https://bugs.openjdk.org/browse/JDK-8342782 ), the performance 
>>> problems observed in 8344697 
>>> <https://bugs.openjdk.org/browse/JDK-8344697> do not reproduce.
>>>
>>> Should I:
>>> A. File a new ticket just to remove the obsolete code?
>>> B. Go ahead and name this new PR after8344697 
>>> <https://bugs.openjdk.org/browse/JDK-8344697> , even though that’s a 
>>> little misleading now?
>>> C. Don’t pursue this, because without a concrete problem / business 
>>> case the OpenJDK community shouldn’t focus on this tech debt.
>>>
>>> Thoughts?
>>>
>>> Regards,
>>>  - Jeremy
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/client-libs-dev/attachments/20250421/e9ea2e1e/attachment.htm>