RFR: 8354466: Open some misc Swing bugs 9 [v3]

[Harshitha Onkar]

On Mon, 21 Apr 2025 17:46:39 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Updating and opening some misc swing bugs
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update color uppercase

LGTM apart from minor inline suggestions

test/jdk/javax/swing/JPasswordField/bug4382819.java line 50:

> 48:             robot.setAutoDelay(250);
> 49:             SwingUtilities.invokeAndWait(() -> createTestUI());
> 50:             robot.waitForIdle();

Add some delay after testUI ?

Suggestion:

            robot.waitForIdle();
            robot.delay(1000);

test/jdk/javax/swing/JPasswordField/bug4382819.java line 59:

> 57:             SwingUtilities.invokeAndWait(() -> passwordField.setEnabled(false));
> 58:             robot.waitForIdle();
> 59:             robot.delay(1000);

delay can be reduced here

Suggestion:

            robot.delay(250);

test/jdk/javax/swing/JSplitPane/bug4820080.java line 68:

> 66:         jleft.setBackground(Color.DARK_GRAY);
> 67:         JPanel jright = new JPanel();
> 68:         jright.setBackground(Color.DARK_GRAY);

using setPreferredSize() makes the UI look better and the divider is not skewed to the left
Same for left and right panels below.

Suggestion:

        JPanel jleft = new JPanel();
        jleft.setBackground(Color.DARK_GRAY);
        jleft.setPreferredSize(new Dimension(100, 100));
        JPanel jright = new JPanel();
        jright.setBackground(Color.DARK_GRAY);

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24703#pullrequestreview-2781960121
PR Review Comment: https://git.openjdk.org/jdk/pull/24703#discussion_r2052826603
PR Review Comment: https://git.openjdk.org/jdk/pull/24703#discussion_r2052827242
PR Review Comment: https://git.openjdk.org/jdk/pull/24703#discussion_r2052835538