RFR: 8354095: Open some JTable bugs 5 [v3]

[Harshitha Onkar]

On Fri, 18 Apr 2025 22:45:39 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Updating and opening some JTable bugs
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   manual jtreg tag, make jtable field local

test/jdk/javax/swing/JTable/InternationalCharacters.java line 173:

> 171:             }
> 172:         };
> 173:         frame.addWindowListener(l);

System.exit(0); is not required in jtreg tests. It needs to be removed.

test/jdk/javax/swing/JTable/bug4118307.java line 64:

> 62:             robot.setAutoDelay(250);
> 63:             SwingUtilities.invokeAndWait(() -> createTestUI());
> 64:             robot.waitForIdle();

robot.delay(1000) ?

test/jdk/javax/swing/JTable/bug4118307.java line 137:

> 135:     static synchronized boolean isFail() {
> 136:         return flag;
> 137:     }

These can be removed once flag is made volatile and flag can directly be used in the test

test/jdk/javax/swing/JTable/bug4118307.java line 158:

> 156:         public int getColumnCount() {
> 157:             return columnNames.length;
> 158:         }

`@Override ` can be added for all the overridden TableModel methods

test/jdk/javax/swing/JTable/bug4138158.java line 40:

> 38:     private static final String INSTRUCTIONS = """
> 39:             Move mouse to beginning of table, press left mouse button and move mouse down
> 40:             so that mouse cursor is below the bottom border of table. If the table isn't

Test instructions are not clear especially this stmt - "mouse cursor is below the bottom border of table". Can we rephrase it for clarity ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24734#discussion_r2052890452
PR Review Comment: https://git.openjdk.org/jdk/pull/24734#discussion_r2052891877
PR Review Comment: https://git.openjdk.org/jdk/pull/24734#discussion_r2052969417
PR Review Comment: https://git.openjdk.org/jdk/pull/24734#discussion_r2052971578
PR Review Comment: https://git.openjdk.org/jdk/pull/24734#discussion_r2052977191