RFR: 8354695: Open source several swing tests batch7 [v2]

Damon Nguyen dnguyen at openjdk.org
Tue Apr 22 01:06:12 UTC 2025


On Mon, 21 Apr 2025 20:18:37 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Syntax fix
>
> test/jdk/javax/swing/JRootPane/bug4403624.java line 79:
> 
>> 77:             SwingUtilities.invokeAndWait(() -> p = b.getLocationOnScreen());
>> 78: 
>> 79:             r.mouseMove(p.x + (b.getWidth() / 2), p.y + (b.getHeight() / 2));
> 
> you called the b.getLocationOnScreen() on EDt but what about b.getWidth() and b.getHeight()

Good point. I was previously advised to remove a `Point.move` call in favor of this, and I didn't put it in the EDT when doing so. Thanks, updated!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24758#discussion_r2053163692


More information about the client-libs-dev mailing list