RFR: 8354248: Open source several AWT GridBagLayout and List tests [v2]

[Tejesh R]

On Fri, 18 Apr 2025 10:58:01 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update review comments
>
> test/jdk/java/awt/GridBagLayout/ComponentShortage.java line 45:
> 
>> 43:     static JTextField jtf;
>> 44:     static Dimension size;
>> 45:     static Dimension fSize;
> 
> Should be Volatile ?
> Accessed on EDT and main thread

Updated.

> test/jdk/java/awt/List/ListScrollbarCursorTest.java line 49:
> 
>> 47:                 """;
>> 48:         PassFailJFrame.builder()
>> 49:                 .title("Test Instructions")
> 
> Title is not required.

Updated.

> test/jdk/java/awt/List/ListScrollbarTest.java line 142:
> 
>> 140:                 l2.addItem(l1.getItem(i));
>> 141:             }
>> 142:             l1.delItems(0, l1.countItems() - 1);    // or l1.clear();
> 
> Is this comment required?

Removed.

> test/jdk/java/awt/List/ListScrollbarTest.java line 143:
> 
>> 141:             }
>> 142:             l1.delItems(0, l1.countItems() - 1);    // or l1.clear();
>> 143:         } else { //else move the selected items
> 
> For consistency in comments
> 
> Suggestion:
> 
>         } else { // else move the selected items

Removed.

> test/jdk/java/awt/List/ListScrollbarTest.java line 150:
> 
>> 148:             for (int i = 0; i < items.length; i++) {
>> 149:                 l2.addItem(items[i]);        // add it
>> 150:                 l2.select(l2.countItems() - 1);// and select it
> 
> Comments are redundant.

Removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24749#discussion_r2053269241
PR Review Comment: https://git.openjdk.org/jdk/pull/24749#discussion_r2053269274
PR Review Comment: https://git.openjdk.org/jdk/pull/24749#discussion_r2053269539
PR Review Comment: https://git.openjdk.org/jdk/pull/24749#discussion_r2053269361
PR Review Comment: https://git.openjdk.org/jdk/pull/24749#discussion_r2053269611