RFR: 8354466: Open some misc Swing bugs 9 [v5]

Harshitha Onkar honkar at openjdk.org
Tue Apr 22 04:20:50 UTC 2025


On Tue, 22 Apr 2025 01:04:56 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Updating and opening some misc swing bugs
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add preferred size to panels

You missed adding the preferred size to the correct panel vars. Please check inline comments

test/jdk/javax/swing/JSplitPane/bug4820080.java line 83:

> 81:         Panel left = new Panel();
> 82:         left.setBackground(Color.DARK_GRAY);
> 83:         jleft.setPreferredSize(new Dimension(100, 100));

Suggestion:

        left.setPreferredSize(new Dimension(100, 100));

test/jdk/javax/swing/JSplitPane/bug4820080.java line 86:

> 84:         Panel right = new Panel();
> 85:         right.setBackground(Color.DARK_GRAY);
> 86:         jleft.setPreferredSize(new Dimension(100, 100));

Suggestion:

        right.setPreferredSize(new Dimension(100, 100));

-------------

PR Review: https://git.openjdk.org/jdk/pull/24703#pullrequestreview-2782712705
PR Review Comment: https://git.openjdk.org/jdk/pull/24703#discussion_r2053299586
PR Review Comment: https://git.openjdk.org/jdk/pull/24703#discussion_r2053299944


More information about the client-libs-dev mailing list