RFR: 8353446: Open source several AWT Menu tests - Batch 2 [v2]

[Tejesh R]

On Tue, 22 Apr 2025 04:44:01 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Tejesh R has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Updated review comments
>>  - Merge branch 'master' of https://git.openjdk.java.net/jdk into branch_8353446
>>  - Open source
>
> test/jdk/java/awt/Menu/DestroyMenuTest/DestroyMenuTest.java line 103:
> 
>> 101:             X.add(topPanel, "North");
>> 102:             X.add(bottomPanel, "South");
>> 103:             frame.add(X, "South");
> 
> Please add constants to add components wherever applicable.
> Suggestion:
> 
>             topPanel.add(vScrollbar, BorderLayout.EAST);
>             topPanel.add(hScrollbar, BorderLayout.SOUTH);
> 
>             X.add(topPanel, BorderLayout.NORTH);
>             X.add(bottomPanel, BorderLayout.SOUTH);
>             frame.add(X, BorderLayout.SOUTH);

Updated.

> test/jdk/java/awt/Menu/OnFlyRepaintMenuTest.java line 50:
> 
>> 48:                 1. Click the button 'Change state' and wait for 5 secs.
>> 49:                 2. If menu is repainted correctly after its setLabel()
>> 50:                    and setEnabled() methods called test PASSED, else FAILED.
> 
> How to know that correct menu is repainted ?
> 
> You may add the initial menu details... like menu labels, menu state, menu checked state etc.
> And then after clicks... what change is expected ?
> 
> This will give tester an info to compare against the test instructions.

repainted correctly after setLabel and setEnabled is evident that its w.r.t to label and enable/disable.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24681#discussion_r2053339487
PR Review Comment: https://git.openjdk.org/jdk/pull/24681#discussion_r2053338954