RFR: 8353445: Open source several AWT Menu tests - Batch 1 [v7]
Abhishek Kumar
abhiscxk at openjdk.org
Tue Apr 22 05:22:48 UTC 2025
On Tue, 22 Apr 2025 05:19:42 GMT, Tejesh R <tr at openjdk.org> wrote:
>> Open source these AWT Menu tests:
>>
>> java/awt/Menu/MenuVisibilityTest/MenuVisibilityTest.java
>> java/awt/Menu/MenuActionEventTest/MenuActionEventTest.java
>> java/awt/Menu/RmInHideTest/RmInHideTest.java
>> java/awt/Menu/SetShortCutTest/SetShortCutTest.java
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>
> Updated review comments
test/jdk/java/awt/Menu/SetShortCutTest.java line 106:
> 104: }
> 105:
> 106: public void actionPerformed(ActionEvent event) {
Add `@Override` here as well
test/jdk/java/awt/Menu/SetShortCutTest.java line 113:
> 111: }
> 112:
> 113: //Click on the "Stuff" menu to remove the "first" menu item
Suggestion:
// Click on the "Stuff" menu to remove the "first" menu item
test/jdk/java/awt/Menu/SetShortCutTest.java line 116:
> 114: else if (event.getSource() == item2) {
> 115: //If the item has not been removed from the menu,
> 116: //then remove "First" from the "File" menu
Suggestion:
// If the item has not been removed from the menu,
// then remove "First" from the "File" menu
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24649#discussion_r2053345722
PR Review Comment: https://git.openjdk.org/jdk/pull/24649#discussion_r2053346577
PR Review Comment: https://git.openjdk.org/jdk/pull/24649#discussion_r2053346858
More information about the client-libs-dev
mailing list