RFR: 8355179: Reinstate javax/swing/JScrollBar/4865918/bug4865918.java headful and macos run
Abhishek Kumar
abhiscxk at openjdk.org
Tue Apr 22 12:01:50 UTC 2025
On Mon, 21 Apr 2025 11:29:03 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
> Now that CI linux system is transitioned, the [JDK-8346828](https://bugs.openjdk.org/browse/JDK-8346828) changes is reverted and test is made headful and run on all platforms including macos.
> CI testing is ok now..
test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java line 1:
> 1: /*
If the test is restored to it's previous version, is it correct to restore copyright year also ?
test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java line 1:
> 1: /*
If the test is restored to it's previous version, is it correct to restore copyright year also ?
test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java line 35:
> 33: import java.awt.event.MouseAdapter;
> 34: import java.awt.event.MouseEvent;
> 35: import java.awt.Robot;
Suggestion:
import java.awt.Dimension;
import java.awt.Robot;
import java.awt.event.MouseAdapter;
import java.awt.event.MouseEvent;
test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java line 88:
> 86:
> 87: private static void createAndShowGUI() {
> 88: frame = new JFrame("bug4865918");
`frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);` was set in the initial test but not now.
Is it required to restore?
Also there was a delay of 200ms after waiting for timeout, that is also not restored.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24774#discussion_r2053963164
PR Review Comment: https://git.openjdk.org/jdk/pull/24774#discussion_r2053963646
PR Review Comment: https://git.openjdk.org/jdk/pull/24774#discussion_r2053941270
PR Review Comment: https://git.openjdk.org/jdk/pull/24774#discussion_r2053961358
More information about the client-libs-dev
mailing list