RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v24]

[Alexey Ivanov]

On Wed, 12 Mar 2025 11:00:30 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is shown without radiobutton in WIndowsLookAndFeel as there was no provision of drawing the radiobutton alongside icon.
>> If icon is not there, the radiobutton is drawn. Added provision of drawing the radiobutton windows Skin even when imageIcon is present.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments fix

I'm pretty sure the previous code was correct. You can combine both `MIIM_STRING | MIIM_BITMAP` for `MENUITEMINFO` but you couldn't and can't combine `MFT_BITMAP`, `MFT_SEPARATOR` with `MFT_STRING`.

`MIIM_BITMAP` is a new flag for `hbmpItem` that was added in Windows 98 and wasn't available in Windows 95 which used only `MFT_BITMAP` or `MFT_STRING`.

Yet I still didn't have enough time to look thoroughly at this native sample as well as the updates to JDK code.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23324#issuecomment-2821687030