RFR: JDK-8353486 : Open source Swing Tests - Set 4 [v9]

[Alexey Ivanov]

On Tue, 22 Apr 2025 16:29:28 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Open-sourced the following Swing tests:
>> 
>> 1. javax/swing/JFileChooser/bug4464774.java
>> 2. javax/swing/JFileChooser/bug4522756.java
>> 3. javax/swing/JFileChooser/bug4759934.java
>> 4. javax/swing/JFileChooser/bug4943900.java
>> 5. javax/swing/JOptionPane/bug4194862.java
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   minor

Marked as reviewed by aivanov (Reviewer).

test/jdk/javax/swing/JFileChooser/bug4522756.java line 47:

> 45:                go up to the desktop.
> 46: 
> 47:             If the above is true press PASS else FAIL.

Suggestion:

            If the above is true, press PASS else FAIL.

You've got a comma here in other tests.

test/jdk/javax/swing/JFileChooser/bug4943900.java line 40:

> 38: 
> 39: public class bug4943900 {
> 40:     private static final String INSTRUCTIONS = """

The instructions look quite ugly on macOS, the frame with the instructions is too wide. I guess it's because you had to increase the width to accommodate for a smaller monospaced font on Windows.

One way to avoid the issue is to use HTML formatting. (This would also handle word-wrapping.)

Another way is to use regular string, rather than a text block, and rely on word-wrapping.

It's only cosmetic, though.

-------------

PR Review: https://git.openjdk.org/jdk/pull/24456#pullrequestreview-2784685823
PR Review Comment: https://git.openjdk.org/jdk/pull/24456#discussion_r2054464150
PR Review Comment: https://git.openjdk.org/jdk/pull/24456#discussion_r2054468745