RFR: JDK-8353486 : Open source Swing Tests - Set 4 [v10]

Tue Apr 22 17:12:01 UTC 2025

On Tue, 22 Apr 2025 16:50:17 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Open-sourced the following Swing tests:
>> 
>> 1. javax/swing/JFileChooser/bug4464774.java
>> 2. javax/swing/JFileChooser/bug4522756.java
>> 3. javax/swing/JFileChooser/bug4759934.java
>> 4. javax/swing/JFileChooser/bug4943900.java
>> 5. javax/swing/JOptionPane/bug4194862.java
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   minor update

Changes requested by aivanov (Reviewer).

test/jdk/javax/swing/JFileChooser/bug4943900.java line 61:

> 59:         press <b>Fail</b></p>.
> 60:         </html>
> 61:         """;

Use proper HTML:

Suggestion:

    private static final String INSTRUCTIONS = """
        <html>
        <ol>
        <li>When the test runs, a <code>JFileChooser</code> will be displayed.

        <li>Ensure that there is a filter combo box with these two items:
          <ul>
          <li><b>Text Files (*.txt)</b>
              — <em>[must be selected when the dialog opens]</em>
          <li><b>All Files</b>
          </ul>

        <li>Leave the <b>Text files</b> item selected and check that the
        filter works: only <code>*.txt</code> files can appear in the file list.
        You can navigate directories in the file chooser and find one
        that contains some <code>*.txt</code> files to ensure they are shown in
        the file list. On macOS when the text filter is applied verify
        that the non-text files are greyed out.

        <li>Try switching the filters and ensure that the file list
        is updated properly.

        <li>If the <code>FileFilter</code> works correctly,
            press <b>Pass</b> else press <b>Fail</b>.
        </ol>
        </html>
        """;

-------------

PR Review: https://git.openjdk.org/jdk/pull/24456#pullrequestreview-2784770399
PR Review Comment: https://git.openjdk.org/jdk/pull/24456#discussion_r2054516242