RFR: 8354695: Open source several swing tests batch7 [v3]

Damon Nguyen dnguyen at openjdk.org
Tue Apr 22 18:00:44 UTC 2025


On Tue, 22 Apr 2025 16:59:28 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move width and height to EDT
>
> test/jdk/javax/swing/JScrollPane/AcceleratedWheelScrolling/RTLScrollers.java line 26:
> 
>> 24: // A few Swing components which use the mouse wheel to scroll
>> 25: //
>> 26: // NOTE: The robot portion of this test probably has a number of EDT problems,
> 
> Yikes. You know that there are EDT problems but just decided to ignore them. Are there a lot of them? How hard it would be to get rid of them?

That's a remnant from the original test. I tried cleaning up the robot calls and test methods further. Re-tested `HorizScrollers` on my windows machine and all still looks good. I don't see how it's feasible to call all the methods in EDT in this JDialog helper class. So far the test looks ok and I have not encountered any issues, but let me know if you have any suggestions or concerns.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24758#discussion_r2054593708


More information about the client-libs-dev mailing list