RFR: 8354695: Open source several swing tests batch7 [v5]

Alexander Zuev kizune at openjdk.org
Tue Apr 22 18:40:42 UTC 2025


On Tue, 22 Apr 2025 18:34:24 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Open-sourcing and standardizing several swing tests (JScrollPane & JRootPane)
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add to EDT

test/jdk/javax/swing/JScrollPane/AcceleratedWheelScrolling/RTLScrollers.java line 276:

> 274:             try {
> 275:                 retVal = rtl.runTests(scrollAmount);
> 276:                 rtl.setVisible(false);

Since you are creating an instance for each test scenario i would put the setVisible(false) into the finally {} clause so it will be called even if runTests throws an exception and add the dispose() call for good measure.

test/jdk/javax/swing/JScrollPane/AcceleratedWheelScrolling/RTLScrollers.java line 677:

> 675:         });
> 676:     }
> 677: }

github complains about lack of the new line at the end. Minor but still :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24758#discussion_r2054663537
PR Review Comment: https://git.openjdk.org/jdk/pull/24758#discussion_r2054664609


More information about the client-libs-dev mailing list