RFR: 8355366: Fix the wrong usage of PassFailJFrame.forcePass() in some manual tests
Alexey Ivanov
aivanov at openjdk.org
Wed Apr 23 19:49:45 UTC 2025
On Wed, 23 Apr 2025 09:35:25 GMT, Manukumar V S <mvs at openjdk.org> wrote:
> Fix the wrong usage of PassFailJFrame.forcePass() in some manual tests from java.awt.Desktop package. These tests should be fixed similar to [JDK-8352109](https://bugs.openjdk.org/browse/JDK-8352109) and jtreg.SkippedException should be used instead of PassFailJFrame.forcePass().
> Affected tests:
> 1. https://github.com/openjdk/jdk/blob/master/test/jdk/java/awt/Desktop/BrowseTest.java
> 2. https://github.com/openjdk/jdk/blob/master/test/jdk/java/awt/Desktop/OpenTest.java
> 3. https://github.com/openjdk/jdk/blob/master/test/jdk/java/awt/Desktop/EditAndPrintTest/EditAndPrintTest.java
>
> Testing:
> All the changed tests are tested manually and found to be working fine.
Looks good to me.
Thank you for updating these tests to throw `SkippedException` instead of pretending to pass.
Update copyright years in all the updated files.
-------------
Changes requested by aivanov (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24820#pullrequestreview-2788534540
More information about the client-libs-dev
mailing list