RFR: 8355441: Remove antipattern from PassFailJFrame.forcePass javadoc [v2]
Manukumar V S
mvs at openjdk.org
Thu Apr 24 15:06:50 UTC 2025
On Thu, 24 Apr 2025 14:22:00 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comments fixed : Formatting changes, added reference to a real test
>
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1310:
>
>> 1308: * PassFailJFrame.forceFail("TEST FAILED (output file - " + output + ")");
>> 1309: * }
>> 1310: * </code></pre>
>
> Shall we scrap the sample completely? It doesn't add clarity.
>
> However, this new sample illustrates the use of both `forcePass` and `forceFail`. A section in the javadoc for the class could be better fit for such kind of example.
>
> Linking to a real test which uses these methods could be beneficial, too.
Added link to a real test
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24837#discussion_r2058663677
More information about the client-libs-dev
mailing list