RFR: 8355441: Remove antipattern from PassFailJFrame.forcePass javadoc [v2]
Manukumar V S
mvs at openjdk.org
Fri Apr 25 02:08:05 UTC 2025
On Thu, 24 Apr 2025 16:32:11 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comments fixed : Formatting changes, added reference to a real test
>
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1305:
>
>> 1303: * <p> A sample usage can be found in this test :
>> 1304: * <a href="https://github.com/openjdk/jdk/blob/master/test/jdk/java/awt/FileDialog/SaveFileNameOverrideTest.java#L84">SaveFileNameOverrideTest.java</a>
>> 1305: *
>
> Suggestion:
>
> * Forcibly pass the test.
> * <p>
> * Use this method in semi-automatic tests when
> * the test determines that all the conditions for passing the test are met.
> * <p>
> * <strong>Do not use</strong> this method in cases where a resource is unavailable or a
> * feature isn't supported, throw {@code jtreg.SkippedException} instead.
> *
> * <p>A sample usage can be found in
> * <a href="https://github.com/openjdk/jdk/blob/7283c8b/test/jdk/java/awt/FileDialog/SaveFileNameOverrideTest.java#L84">{@code
> * SaveFileNameOverrideTest.java}</a>
>
> This way looks better to me.
>
> You want a permanent link; the test could change in the future.
Yea, the line number might change, so I just removed the line number in the link.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24837#discussion_r2059456056
More information about the client-libs-dev
mailing list