RFR: 8355441: Remove antipattern from PassFailJFrame.forcePass javadoc [v3]
Alexey Ivanov
aivanov at openjdk.org
Fri Apr 25 18:13:47 UTC 2025
On Fri, 25 Apr 2025 02:08:04 GMT, Manukumar V S <mvs at openjdk.org> wrote:
>> The javadoc for PassFailJFrame.forcePass suggests an anti-pattern of forcibly passing the test if a resource is unavailable.
>>
>> If a resource is unavailable or a feature isn't supported, the test should throw jtreg.SkippedException.
>>
>> PassFailJFrame.forcePass should be used in semi-automatic tests when the test determines that all the conditions for passing the test are met.
>> Please refer: JDK-8355366 and https://github.com/openjdk/jdk/pull/24820
>>
>> Testing
>> This is a javadoc change, so not testing required.
>
> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
>
> Updated the javadoc description
Add the link to the particular line number — it's more helpful.
`blob/7283c8b` refers the commit 7283c8b that can never change.
-------------
Changes requested by aivanov (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24837#pullrequestreview-2794914236
More information about the client-libs-dev
mailing list