RFR: 8351884: Refactor bug8033699.java test code [v3]
Alexey Ivanov
aivanov at openjdk.org
Fri Apr 25 19:52:06 UTC 2025
On Fri, 25 Apr 2025 16:55:40 GMT, Rajat Mahajan <rmahajan at openjdk.org> wrote:
>> Details:
>> Refactored code as requested in the Bug description.
>>
>> Tested and verified the test passes.
>
> Rajat Mahajan has updated the pull request incrementally with one additional commit since the last revision:
>
> code changes as per code review
test/jdk/javax/swing/JRadioButton/8033699/bug8033699.java line 183:
> 181: mainFrame.getContentPane()
> 182: .setLayout(new BoxLayout(mainFrame.getContentPane(),
> 183: BoxLayout.Y_AXIS));
Suggestion:
This is no longer needed, as you put all those components into `mainBox` which uses `BoxLayout`. Thus, the content pane of `mainFrame` could remain the default `BorderLayout`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24384#discussion_r2060802074
More information about the client-libs-dev
mailing list