RFR: 8355611: Get rid of SurfaceManagerFactory [v2]
Phil Race
prr at openjdk.org
Fri Apr 25 21:09:46 UTC 2025
On Fri, 25 Apr 2025 14:19:54 GMT, Nikita Gubarkov <ngubarkov at openjdk.org> wrote:
>> `SurfaceManagerFactory` just checks a given `GraphicsConfiguration` against multiple types via `instanceof`, it has 3 platform-specific implementations, which rely on an ugly injection process.
>>
>> There is no reason to have this class at all, we could just let `GraphicsConfiguration` create a compatible `SurfaceManager` instead.
>>
>> This would reduce coupling without having to collect all surface manager types in a single place (without real need to do so).
>> And this would also remove dependency on the class initialization sequence by getting rid of the injection process.
>
> Nikita Gubarkov has updated the pull request incrementally with one additional commit since the last revision:
>
> fixup! 8355611: Get rid of SurfaceManagerFactory
It seems like a nice simplification, but I'm running all our tests to make sure there are no unpleasant surprises.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24875#issuecomment-2831432561
More information about the client-libs-dev
mailing list