RFR: 8355611: Get rid of SurfaceManagerFactory [v3]
Sergey Bylokhov
serb at openjdk.org
Sun Apr 27 03:34:45 UTC 2025
On Sat, 26 Apr 2025 11:07:04 GMT, Nikita Gubarkov <ngubarkov at openjdk.org> wrote:
>> `SurfaceManagerFactory` just checks a given `GraphicsConfiguration` against multiple types via `instanceof`, it has 3 platform-specific implementations, which rely on an ugly injection process.
>>
>> There is no reason to have this class at all, we could just let `GraphicsConfiguration` create a compatible `SurfaceManager` instead.
>>
>> This would reduce coupling without having to collect all surface manager types in a single place (without real need to do so).
>> And this would also remove dependency on the class initialization sequence by getting rid of the injection process.
>
> Nikita Gubarkov has updated the pull request incrementally with three additional commits since the last revision:
>
> - fixup! 8355611: Get rid of SurfaceManagerFactory
>
> Remove SurfaceManager.Factory interface from XRGraphicsConfig.
> - fixup! 8355611: Get rid of SurfaceManagerFactory
>
> Split long lines (8339341)
> - fixup! 8355611: Get rid of SurfaceManagerFactory
>
> Split long lines
Marked as reviewed by serb (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/24875#pullrequestreview-2796904707
More information about the client-libs-dev
mailing list