RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java [v8]
Alexey Ivanov
aivanov at openjdk.org
Mon Apr 28 14:47:56 UTC 2025
On Fri, 25 Apr 2025 20:18:27 GMT, Alisen Chung <achung at openjdk.org> wrote:
>> Anass Baya has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Frame null-check before disposing the frame on the EDT
>
> test/jdk/javax/swing/JComboBox/ComboPopupBug.java line 44:
>
>> 42: private static JFrame frame;
>> 43: private static JButton closeButton;
>> 44: private static JComboBox<String> comboBox;
>
> can remove <String>
No, `JComboBox<String>` is the correct type, you shouldn't use plain `JComboBox` without declaring which elements are stored there.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24624#discussion_r2063823809
More information about the client-libs-dev
mailing list