RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java [v8]
Alexey Ivanov
aivanov at openjdk.org
Mon Apr 28 14:56:48 UTC 2025
On Fri, 25 Apr 2025 20:13:31 GMT, Alisen Chung <achung at openjdk.org> wrote:
>> Anass Baya has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Frame null-check before disposing the frame on the EDT
>
> test/jdk/javax/swing/JComboBox/ComboPopupBug.java line 93:
>
>> 91: });
>> 92:
>> 93: frame.getContentPane().add(comboBox, "North");
>
> dont need .getContentPane()
It's not wrong to use `.getContentPane()`, it was the only correct way for a long time.
Removing `.getContentPane()` doesn't change much, and it was there.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24624#discussion_r2063846216
More information about the client-libs-dev
mailing list