Integrated: 8355441: Remove antipattern from PassFailJFrame.forcePass javadoc

Manukumar V S mvs at openjdk.org
Tue Apr 29 16:45:51 UTC 2025


On Wed, 23 Apr 2025 23:50:06 GMT, Manukumar V S <mvs at openjdk.org> wrote:

> The javadoc for PassFailJFrame.forcePass suggests an anti-pattern of forcibly passing the test if a resource is unavailable.
> 
> If a resource is unavailable or a feature isn't supported, the test should throw jtreg.SkippedException.
> 
> PassFailJFrame.forcePass should be used in semi-automatic tests when the test determines that all the conditions for passing the test are met.
> Please refer: JDK-8355366 and https://github.com/openjdk/jdk/pull/24820
> 
> Testing
> This is a javadoc change, so not testing required.

This pull request has now been integrated.

Changeset: bd7561c3
Author:    Manukumar V S <mvs at openjdk.org>
Committer: Harshitha Onkar <honkar at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/bd7561c315e8fd80e32cb154998bd28745c98682
Stats:     10 lines in 1 file changed: 2 ins; 0 del; 8 mod

8355441: Remove antipattern from PassFailJFrame.forcePass javadoc

Reviewed-by: aivanov, honkar

-------------

PR: https://git.openjdk.org/jdk/pull/24837


More information about the client-libs-dev mailing list