RFR: 8355904: Use variadic macros for J2dTrace [v2]
Nikita Gubarkov
ngubarkov at openjdk.org
Wed Apr 30 06:17:50 UTC 2025
On Wed, 30 Apr 2025 03:16:49 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>> Nikita Gubarkov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> fixup! 8355904: Use variadic macros for J2dTrace
>
> src/java.desktop/share/native/libawt/java2d/Trace.h line 58:
>
>> 56: #ifndef DEBUG
>> 57: #define J2dTrace(level, ...)
>> 58: #define J2dTraceLn(level, ...)
>
> This looks fine, but maybe the string argument could be included as a parameter? Would that improve usability, like better error messages when no arguments are provided, or enhance auto-completion in the IDE?"
There is a trailing comma problem when passing no extra args. I didn't figure out how to solve it without `__VA_OPT__` or compiler-specific tricks, so I moved the string into variadic part, so that it always has at least one parameter.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24949#discussion_r2067922150
More information about the client-libs-dev
mailing list