RFR: 8352149: open/test/jdk/java/awt/Frame/MultiScreenTest.java fails [v2]

Khalid Boulanouare duke at openjdk.org
Wed Apr 30 20:59:49 UTC 2025


On Wed, 30 Apr 2025 17:21:21 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>>> #21942
>> 
>> Thanks @aivanov-jdk for suggesting the correct route.
>> 
>> @kboulanou Please modify the test to run for all platforms and you can limit the number of graphics configuration to 10 for linux.
>
>> @kumarabhi006 I am aware that I should not force push to PR. But, I made the mistake of pushing updates (sync) from master to this PR so it added 200 commits to this PR, which will make the PR confusing. I should have updated master and fork and rebased my branch on it and then push to PR. I will be more careful in the future. Please suggest if this is OK. Thanks.
> 
> @kboulanou Merging master is safe.
> 
> **Don't use `git rebase`**, though. Never use `git rebase` after you published your branch for PR.
> 
> If you merge (sync) changes from master, Git won't show them as differences. The PR compares your branch to master. By merging, you add more commits that already exist in master, which means no changes between master and your branch are added.

@aivanov-jdk Thank you for explaining how to include new master branch changes to PR, the right way. I will stick to this in the future and make sure PR respect history from master branch. Thank you again.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24752#issuecomment-2843263633


More information about the client-libs-dev mailing list