RFR: 8364230: javax/swing/text/StringContent can be migrated away from using finalize
Prasanta Sadhukhan
psadhukhan at openjdk.org
Fri Aug 1 05:25:53 UTC 2025
On Mon, 28 Jul 2025 22:38:03 GMT, Phil Race <prr at openjdk.org> wrote:
> Convert StringContent's Position usage tracking to use a WeakReference
>
> The test that is added only implicitly tests this but I added it because of a complete lack of any test for this code.
test/jdk/javax/swing/text/AbstractDocument/StringContentPositionTest.java line 65:
> 63: for (int i=0; i<SIZE; i++) {
> 64: if (positions[i].getOffset() != 0) {
> 65: System.err.println("remove: Bad offset i=" + i + " off=" + positions[i].getOffset());
Why a RuntimeException is not thrown instead of just logging?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26519#discussion_r2246935417
More information about the client-libs-dev
mailing list