RFR: 4938801: The popup does not go when the component is removed [v8]

[Prasanta Sadhukhan]

On Fri, 1 Aug 2025 06:22:23 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rename listener class
>
> test/jdk/javax/swing/JPopupMenu/TestPopupInvoker.java line 53:
> 
>> 51: 
>> 52:     private static final CountDownLatch popupShown = new CountDownLatch(1);
>> 53:     private static final CountDownLatch popupHidden = new CountDownLatch(1);
> 
> Final variables can be capitalized.

It is not a constant so no need.

> test/jdk/javax/swing/JPopupMenu/TestPopupInvoker.java line 106:
> 
>> 104:                 pane.repaint();
>> 105:             });
>> 106:             if (!popupHidden.await(1, SECONDS)) {
> 
> is it ok to have the same timeout for both latches ?
> If yes, then a final TIMEOUT variable can be declared and used.

"show" sometimes might take more time so I guess different timeout is ok..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26407#discussion_r2247168368
PR Review Comment: https://git.openjdk.org/jdk/pull/26407#discussion_r2247172191