RFR: 8339791: Refactor MiscUndecorated/ActiveAWTWindowTest.java
Abhishek Kumar
abhiscxk at openjdk.org
Fri Aug 1 07:21:56 UTC 2025
On Fri, 1 Aug 2025 06:08:12 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> test/jdk/java/awt/Frame/MiscUndecorated/ActiveAWTWindowTest.java line 59:
>>
>>> 57: private static final CountDownLatch windowActivatedLatch = new CountDownLatch(1);
>>> 58: private static final CountDownLatch windowDeactivatedLatch = new CountDownLatch(1);
>>> 59: private static final CountDownLatch windowFocusGainedLatch = new CountDownLatch(1);
>>
>> I see where we decrement this latch but i do not see where we check it or wait on it. Is it really needed?
>
> also no need to use ExtendedRobot as all I can see is mousePress/mouseRelease which can be used from java.awt.Robot class itself..
static final variables can be capitalized.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26471#discussion_r2247144121
More information about the client-libs-dev
mailing list