RFR: 8361193: Test java/awt/Mixing/AWT_Mixing/MixingPanelsResizing.java fails on MacOS X [v2]
Alisen Chung
achung at openjdk.org
Fri Aug 1 07:36:56 UTC 2025
On Tue, 8 Jul 2025 14:56:23 GMT, Khalid Boulanouare <duke at openjdk.org> wrote:
>> Sets setOpaque for lightweight, and uses a compares colors with tolerance in MacOS X machines.
>
> Khalid Boulanouare has updated the pull request incrementally with one additional commit since the last revision:
>
> Adds extra space after if
>
> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
Please change copyright years for test as well
test/jdk/java/awt/Mixing/AWT_Mixing/MixingPanelsResizing.java line 304:
> 302: }//fail()
> 303: private static boolean isAlmostEqualColor(Color color, Color refColor) {
> 304: final int COLOR_TOLERANCE_MACOSX = 10;
I think this field should go with the other final variables at the top for visibility
-------------
PR Review: https://git.openjdk.org/jdk/pull/26166#pullrequestreview-3078084729
PR Review Comment: https://git.openjdk.org/jdk/pull/26166#discussion_r2247209974
More information about the client-libs-dev
mailing list