RFR: 8358813: JPasswordField identifies spaces in password via delete shortcuts [v2]

Jeremy Wood duke at openjdk.org
Mon Aug 4 05:40:05 UTC 2025


On Thu, 31 Jul 2025 20:55:49 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Jeremy Wood has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - 8358813: putting the actions in a TreeSet
>>    
>>    This is in response to:
>>    https://github.com/openjdk/jdk/pull/25688#discussion_r2200230806
>>  - 8358813: make input map types a static constant
>>    
>>    This is in response to:
>>    https://github.com/openjdk/jdk/pull/25688#discussion_r2200225191
>>  - Merge branch 'master' into JDK-8358813
>>  - Update test/jdk/javax/swing/JPasswordField/PasswordFieldInputMapWordTest.java
>>    
>>    Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>>  - 8358813: remove more bindings for JPasswordFields in Aqua
>
> src/java.desktop/macosx/classes/com/apple/laf/AquaKeyBindings.java line 162:
> 
>> 160:                         "alt BACK_SPACE", null,
>> 161:                         "ctrl W", null,
>> 162:                         "alt DELETE", null
> 
> The change "works" for the test, but I'm not exactly sure what's changed here. When I make my own local test with a JPasswordField, the key binds don't do anything on Aqua. The `CTRL+W` seems to just input `W`. `ALT+BACK_SPACE` seems to just backspace the character before the carat. Can you help me understand this?
> 
> Also, I guess you can end in a trailing comma to match the previous format if you want. Either is OK.

@DamonGuy it sounds like maybe (?) you're not able to reproduce the original ticket?

Here's a video showing what I experience in JDK 24 vs what I see when I use this PR:
https://go.screenpal.com/watch/cTjfh4nI55H

Does this match what you're observing/experiencing, and if not: what do you see instead?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25688#discussion_r2250445813


More information about the client-libs-dev mailing list