RFR: 8158801: [TEST_BUG] Mixing tests fail because of focus workaround trick [v12]
Khalid Boulanouare
duke at openjdk.org
Mon Aug 4 10:07:58 UTC 2025
On Thu, 31 Jul 2025 20:02:11 GMT, Phil Race <prr at openjdk.org> wrote:
>> Khalid Boulanouare has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 21 additional commits since the last revision:
>>
>> - Removes not needed component frace ancestor.
>> - Problem unlists passed tests
>> - Uses frame requestFocus instead of robot clicks for focus
>> - Removes extra Robot waitForIdle
>> - Merge branch 'openjdk:master' into jdk-8158801
>> - Restores copyright year for tests not updated
>> - Removes some tests from problem list
>> - Uses request frame focus instead of Robot clicks to request frame focus
>> - Revert "Changes Frame width to 300, uses protected constants for all base tests frame sizes"
>>
>> This reverts commit b6558c79a129837c3d8d92cdc99d9417e630126d.
>> - Revert "Removes passed tests from problem list"
>>
>> This reverts commit 2f9be981c785ba40574fc5710c0330fb3abc60d2.
>> - ... and 11 more: https://git.openjdk.org/jdk/compare/50b49291...b558508f
>
> I see that you filed all these bugs
> https://bugs.openjdk.org/browse/JDK-8361188
> https://bugs.openjdk.org/browse/JDK-8361189
> https://bugs.openjdk.org/browse/JDK-8361190
> https://bugs.openjdk.org/browse/JDK-8361191
> https://bugs.openjdk.org/browse/JDK-8361192
> https://bugs.openjdk.org/browse/JDK-8361193
> https://bugs.openjdk.org/browse/JDK-8361195
>
> and not one of them has a description or evaluation.
> And the dependencies suggest they aren't completely unrelated.
> Also you will be making "N" problem list updates ..
> This would have been easier for people to follow and you to manage if it was ONE bug and ONE PR.
> I suggest you close all but one and deal with them all together.
>
> Also be a bit more clear in why the change fixes it - I read comments like
> "Changes heavyweight color to white, for the test to pass." - What was the problem and why does that fix it ?
> "Fixes failed test by disabling heavyweight component in ItemListener." - same issues.
>
> I won't repeat everything like that but I need to be confident that you've understood the problem and can explain the fix.
@prrace Since all the listed bugs are sub-tasks of bug JDK-8360498, I will create one PR with this bug and include all fixes in it. I will close all subtask and link them to their parent bug JDK-8360498.
I will proceed with fixes and explain the issues encountered and why I suggest to fix it that way.
Please let me know if this is ok. Thanks.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25971#issuecomment-3149923164
More information about the client-libs-dev
mailing list