RFR: 8361193: Test java/awt/Mixing/AWT_Mixing/MixingPanelsResizing.java fails on MacOS X [v2]
Khalid Boulanouare
duke at openjdk.org
Tue Aug 5 15:19:12 UTC 2025
On Fri, 1 Aug 2025 07:49:22 GMT, Alisen Chung <achung at openjdk.org> wrote:
>> Khalid Boulanouare has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Adds extra space after if
>>
>> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>
> Test is failing for me locally on macOS even after the fix.
> Test fails at line 163: Execution failed: `main' threw exception: java.lang.RuntimeException: JButton was not redrawn properly on AWT Panel during move
> Maybe it would be good to add some debug statements with the color that robot.getPixelColor returns.
@alisenchung I will add debug statements as requested.
> test/jdk/java/awt/Mixing/AWT_Mixing/MixingPanelsResizing.java line 304:
>
>> 302: }//fail()
>> 303: private static boolean isAlmostEqualColor(Color color, Color refColor) {
>> 304: final int COLOR_TOLERANCE_MACOSX = 10;
>
> I think this field should go with the other final variables at the top for visibility
Done. The requested changes is now in PR https://github.com/openjdk/jdk/pull/26625
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26166#issuecomment-3155643037
PR Review Comment: https://git.openjdk.org/jdk/pull/26166#discussion_r2254664239
More information about the client-libs-dev
mailing list