RFR: 8158801: [TEST_BUG] Mixing tests fail because of focus workaround trick [v14]
Khalid Boulanouare
duke at openjdk.org
Wed Aug 6 09:12:53 UTC 2025
On Wed, 6 Aug 2025 07:12:40 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> Khalid Boulanouare has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Removes wildcard imports
>
> test/jdk/java/awt/Mixing/AWT_Mixing/GlassPaneOverlappingTestBase.java line 138:
>
>> 136: FocusManager.getCurrentManager()
>> 137: .getFocusOwner();
>> 138: if (focusOwner == f) {
>
> Guess you should be checking these before calling `requestFocusInWindow` as there's no point in calling `requestFocusInWindow` if current focusOwner is f?
Thanks for pointing this to me. I have changed the code accordingly and running all tests to make sure my change does not break anything.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2256493649
More information about the client-libs-dev
mailing list