RFR: 8358813: JPasswordField identifies spaces in password via delete shortcuts [v4]

Alexey Ivanov aivanov at openjdk.org
Wed Aug 6 13:56:19 UTC 2025


On Wed, 6 Aug 2025 00:08:46 GMT, Jeremy Wood <duke at openjdk.org> wrote:

>> There were a few action bindings available in JPasswordFields in Aqua that let you identify the boundaries of words.
>> 
>> This came to my attention while looking at the related work https://github.com/openjdk/jdk/pull/25443 . In that PR we said we should iterate across all available L&Fs, so this PR copies that same approach. (The original complaint only focused on Aqua, though.)
>
> Jeremy Wood has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains nine additional commits since the last revision:
> 
>  - 8358813: use Set.of
>    
>    This is in response to:
>    https://github.com/openjdk/jdk/pull/25688/files#r2255241147
>  - Merge branch 'master' into JDK-8358813
>  - 8358813: add trailing comma
>    
>    This is in response to:
>    https://github.com/openjdk/jdk/pull/25688/files#r2246362320
>  - Update test/jdk/javax/swing/JPasswordField/PasswordFieldInputMapWordTest.java
>    
>    Co-authored-by: DamonGuy <damon.nguyen at oracle.com>
>  - 8358813: putting the actions in a TreeSet
>    
>    This is in response to:
>    https://github.com/openjdk/jdk/pull/25688#discussion_r2200230806
>  - 8358813: make input map types a static constant
>    
>    This is in response to:
>    https://github.com/openjdk/jdk/pull/25688#discussion_r2200225191
>  - Merge branch 'master' into JDK-8358813
>  - Update test/jdk/javax/swing/JPasswordField/PasswordFieldInputMapWordTest.java
>    
>    Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>  - 8358813: remove more bindings for JPasswordFields in Aqua

test/jdk/javax/swing/JPasswordField/PasswordFieldInputMapWordTest.java line 24:

> 22:  */
> 23: 
> 24: /**

Suggestion:

/*

Please do not use javadoc comment for jtreg tags.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25688#discussion_r2257249271


More information about the client-libs-dev mailing list