RFR: 8364363: Modify some manual test instructions
Alexey Ivanov
aivanov at openjdk.org
Wed Aug 6 20:18:15 UTC 2025
On Tue, 5 Aug 2025 09:33:18 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:
> When testing jtreg manual tests, some tests had unclear instructions. This PR is an attempt at updating these tests for clarity.
>
> `MouseDraggedOriginatedByScrollBarTest.java` works as expected when compared to native apps and outputs drag events even when the mouse pointer is dragged off of the scrollbar and window altogether. Events should still fire, but the previous instructions may make this confusing since it reads as if no events should be output to the textarea at all.
>
> `TextAreaAppendScrollTest2.java` seems to not work when testing with the previous implementation of programmatically appending strings to the textarea. When I scroll down using the down arrow key, none of the text below would be visible when the textarea is scrolled down. However, it would show if I pressed `ENTER` to create a new line or manually modify the text in the textarea first. So instead, I have implemented the original reported approach to the test of adding a button to append a string to the textarea to test for automatic scrolling when the word is wrapped to a new line.
Changes requested by aivanov (Reviewer).
test/jdk/java/awt/List/MouseDraggedOriginatedByScrollBarTest.java line 48:
> 46: 3) The test fails if you see messages about drag
> 47: events for anything other than list0.
> 48: The test passes if you don't.
Is it possible to automate this part? I mean, automatically flag the test as failed (after displaying a message to the tester after dragging is complete).
test/jdk/java/awt/TextArea/TextAreaAppendScrollTest2.java line 71:
> 69: coolStr.append("cool ");
> 70: }
> 71: area.append(coolStr.toString());
Is adding `12 * 15` _cools_ not enough?
The original instructions are pretty clear: if you see the exclamation marks, then auto-scrolling works correctly; otherwise, it auto-scrolling doesn't work as expected and the tester has to click **Fail**.
-------------
PR Review: https://git.openjdk.org/jdk/pull/26636#pullrequestreview-3094081274
PR Review Comment: https://git.openjdk.org/jdk/pull/26636#discussion_r2258176698
PR Review Comment: https://git.openjdk.org/jdk/pull/26636#discussion_r2258188866
More information about the client-libs-dev
mailing list