RFR: 8364808: Make BasicDesktopPaneUI.Actions.MOVE_RESIZE_INCREMENT static
Alexey Ivanov
aivanov at openjdk.org
Thu Aug 7 16:25:16 UTC 2025
On Thu, 19 Jun 2025 08:25:53 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:
> Looks like no reasons for it to be instance field
Marked as reviewed by aivanov (Reviewer).
src/java.desktop/share/classes/javax/swing/plaf/basic/BasicDesktopPaneUI.java line 33:
> 31: import java.beans.*;
> 32:
> 33: import java.awt.event.ActionEvent;
I suggest expanding all the wildcard imports:
import java.awt.Component;
import java.awt.Container;
import java.awt.Dimension;
import java.awt.FocusTraversalPolicy;
import java.awt.Graphics;
import java.awt.Insets;
import java.awt.KeyboardFocusManager;
import java.awt.Point;
import java.awt.event.ActionEvent;
import java.beans.PropertyChangeEvent;
import java.beans.PropertyChangeListener;
import java.beans.PropertyVetoException;
import javax.swing.AbstractAction;
import javax.swing.DefaultDesktopManager;
import javax.swing.DesktopManager;
import javax.swing.InputMap;
import javax.swing.JComponent;
import javax.swing.JDesktopPane;
import javax.swing.JInternalFrame;
import javax.swing.KeyStroke;
import javax.swing.LookAndFeel;
import javax.swing.SortingFocusTraversalPolicy;
import javax.swing.SwingUtilities;
import javax.swing.UIManager;
import javax.swing.plaf.ComponentUI;
import javax.swing.plaf.DesktopPaneUI;
import javax.swing.plaf.UIResource;
import sun.swing.DefaultLookup;
import sun.swing.UIAction;
-------------
PR Review: https://git.openjdk.org/jdk/pull/25893#pullrequestreview-3097887826
PR Review Comment: https://git.openjdk.org/jdk/pull/25893#discussion_r2260823380
More information about the client-libs-dev
mailing list