RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v30]

[Alexey Ivanov]

On Thu, 26 Jun 2025 14:55:32 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   MenuItem with icon fix
>
> src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsCheckBoxMenuItemUI.java line 81:
> 
>> 79:      * Paint MenuItem.
>> 80:      */
>> 81:     protected void paintMenuItem(Graphics g, JComponent c,
> 
> This javadoc doesn't add anything on top of what's in the overridden method, remove the javadoc.
> 
> Add `@Override` annotation.

Again neither of the points raised in this comment has been addressed.

The should be no explicit javadoc, or at least `{@inheritDoc}`, since the overridden method doesn't do anything specific that needs documenting.

> src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsMenuItemUI.java line 157:
> 
>> 155:                     UIManager.getColor(prefix + ".disabledForeground");
>> 156:         }
>> 157:     }
> 
> I'm not convinced `installDefaults` needs overriding, `BasicMenuItemUI` already provides all these colors via its `BasicMenuItemUI.installDefaults` method and protected fields.

This is not addressed / resolved at all — you've just marked the comment as resolved. Why is it?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r2266511453
PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r2266508247