RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v38]

[Phil Race]

On Mon, 4 Aug 2025 05:31:46 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is shown without radiobutton in WIndowsLookAndFeel as there was no provision of drawing the radiobutton alongside icon.
>> If icon is not there, the radiobutton is drawn. Added provision of drawing the radiobutton windows Skin even when imageIcon is present.
>
> Prasanta Sadhukhan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 42 commits:
> 
>  - Merge branch 'master' of https://git.openjdk.java.net/jdk into JDK-8348760
>  - Fix not needed background effect for Windows 10
>  - Remove Windows version check
>  - Merge master
>  - bullet/checkmark placement for varying imageicon size fix, test update
>  - Adjust offset for varying size imageicon
>  - squish fix
>  - Alignment fix
>  - MenuItem with icon fix
>  - Merge branch 'master' of https://git.openjdk.java.net/jdk into JDK-8348760
>  - ... and 32 more: https://git.openjdk.org/jdk/compare/57553ca1...5f51ecdc

src/java.desktop/share/classes/com/sun/java/swing/SwingUtilities3.java line 251:

> 249: 
> 250:     public static void setAcceleratorSelectionForeground(Color acceleratorSelectionFg) {
> 251:         acceleratorForeground = acceleratorSelectionFg;

I just noticed this "oops". This should be acceleratorSelectionForeground.
Do we not have a test that would spot this ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r2267210782