RFR: 8365389: Remove static color fields from SwingUtilities3 and WindowsMenuItemUI [v2]

Alexey Ivanov aivanov at openjdk.org
Thu Aug 14 20:02:16 UTC 2025


On Thu, 14 Aug 2025 16:55:35 GMT, Phil Race <prr at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8365389
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicMenuItemUI.java line 719:
> 
>> 717:     private void paintAccText(Graphics g, MenuItemLayoutHelper lh,
>> 718:                               MenuItemLayoutHelper.LayoutResult lr) {
>> 719:         SwingUtilities3.paintAccText(g, lh, lr,
> 
> I left this private method here rather than calling the SU3 code directly because this method was here all along, before the previous fix. Same for a couple of others.

Previously, these private methods did the work that's now performed by the new methods in `SwingUtilities3`.

It's fine to postpone removing these private methods.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26783#discussion_r2277595953


More information about the client-libs-dev mailing list