RFR: 8365389: Remove static color fields from SwingUtilities3 and WindowsMenuItemUI [v2]

Alexey Ivanov aivanov at openjdk.org
Fri Aug 15 15:20:12 UTC 2025


On Thu, 14 Aug 2025 16:53:27 GMT, Phil Race <prr at openjdk.org> wrote:

>> This refactors some Swing code to pass args instead of using statics
>> The bug report suggests some further refactoring which could be considered later, but the most
>> important thing to do is to eliminate using statics to pass args.
>> I've added one other suggestion from the bug report to have the windows case call SU3 directly rather than via newly added static methods, but for the basic case, I left the pre-existing private instance methods.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8365389

There are still static fields to store colors in `WindowsMenuItemUI`, do you want to get rid of those too? My bug report implied removing them, yet currently the static fields with colors remain intact in `WindowsMenuItemUI`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26783#issuecomment-3191760275


More information about the client-libs-dev mailing list