RFR: 8365708: Add missing @Override annotations to WindowsMenuItemUIAccessor
Alexey Ivanov
aivanov at openjdk.org
Mon Aug 18 17:22:17 UTC 2025
On Mon, 18 Aug 2025 17:15:47 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>> Add the missing `@Override` annotations to anonymous classes implementing `WindowsMenuItemUIAccessor`.
>>
>> PR #24170 for [JDK-8352638](https://bugs.openjdk.org/browse/JDK-8352638) added the `@Override` annotations to `getMenuItem` and `getPart` but left `getState` without the annotation.
>>
>> For consistency, add the annotation to the `getState` method too.
>
> src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsCheckBoxMenuItemUI.java line 55:
>
>> 53: }
>> 54:
>> 55: @Override
>
> There is the new paintMenuItem method below which can be annotated as well.
This is handled in #26826.
I thought about combining both fixes at first, but decided against it. The fix for [JDK-8365625](https://bugs.openjdk.org/browse/JDK-8365625) in PR #26826 will be backported to all supported releases. Yet there's no need to backport either JDK-8365708 (this one) nor [JDK-8352638](https://bugs.openjdk.org/browse/JDK-8352638 "Enhance code consistency: java.desktop/windows").
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26828#discussion_r2282998734
More information about the client-libs-dev
mailing list