RFR: 8158801: [TEST_BUG] Mixing tests fail because of focus workaround trick [v23]

Khalid Boulanouare duke at openjdk.org
Tue Aug 19 09:30:13 UTC 2025


On Tue, 19 Aug 2025 04:18:45 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Khalid Boulanouare has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updates copyright years
>
> test/jdk/java/awt/Mixing/AWT_Mixing/GlassPaneOverlappingTestBase.java line 135:
> 
>> 133:                                 testedComponent.getPreferredSize().height + 20);
>> 134:                         Component focusOwner = FocusManager.getCurrentManager()
>> 135:                                 .getFocusOwner();
> 
> Usually we use `KeyboardFocusManager.getCurrentKeyboardFocusManager().getFocusOwner()`

Requested change committed.

> test/jdk/java/awt/Mixing/AWT_Mixing/ViewportOverlapping.java line 100:
> 
>> 98:         f.setLocationRelativeTo(null);
>> 99:         f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
>> 100:         f.setLocationRelativeTo(null);
> 
> it already calls `setLocationRelativeTo` above..

Changes reverted.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2284671477
PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2284670526


More information about the client-libs-dev mailing list