RFR: 8365569: Remove finalize from JavaSoundAudioClip.java
Andrey Turbanov
aturbanov at openjdk.org
Tue Aug 19 14:25:39 UTC 2025
On Thu, 14 Aug 2025 17:27:09 GMT, Phil Race <prr at openjdk.org> wrote:
> This refactors com/sun/media/sound/JavaSoundAudioClip.java so that most of the implementation is in a delegate
> com/sun/media/sound/JavaSoundAudioClipDelegate.java
>
> Then a disposer can be used to free the audio resources held by the delegate when the JavaSoundAudioClip becomes unreachable.
src/java.desktop/share/classes/com/sun/media/sound/JavaSoundAudioClipDelegate.java line 296:
> 294: // FILE LOADING METHODS
> 295:
> 296: private boolean loadAudioData(AudioInputStream as) throws IOException, UnsupportedAudioFileException {
Suggestion:
private boolean loadAudioData(AudioInputStream as) throws IOException, UnsupportedAudioFileException {
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26784#discussion_r2285446512
More information about the client-libs-dev
mailing list