RFR: 8361067: Test ExtraButtonDrag.java requires frame.dispose in finally block [v9]

Damon Nguyen dnguyen at openjdk.org
Wed Aug 20 16:50:44 UTC 2025


On Wed, 6 Aug 2025 09:43:48 GMT, Ravi Gupta <rgupta at openjdk.org> wrote:

>> Test test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ExtraButtonDrag.java left debris on system whenever fails its required frame.dispose() in finally block.
>> 
>> 
>>  finally {
>>             EventQueue.invokeAndWait(ExtraButtonDrag::disposeFrame);
>>         }
>>     public static void disposeFrame() {
>>         if (frame != null) {
>>             frame.dispose();
>>             frame = null;
>>         }
>>     }
>
> Ravi Gupta has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8361067: Added review comment

Re-tested and works fine as explained. Issue was on my end and was resolved.

-------------

Marked as reviewed by dnguyen (Committer).

PR Review: https://git.openjdk.org/jdk/pull/26043#pullrequestreview-3137482817


More information about the client-libs-dev mailing list