RFR: 8365425: [macos26] javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java fails on macOS 26
Damon Nguyen
dnguyen at openjdk.org
Wed Aug 20 22:25:17 UTC 2025
On Tue, 19 Aug 2025 06:14:21 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
> Test compares specific pixels with expected color and needed color profile setting in macOS26 is not available it seems.
> Since the pixel color difference is slightly off, I have added a tolerance which had been present in many other tests so it's not without precedent
The suggestion to use a BufferedImage sounds fair.
The fix here does make the test pass consistently when testing on a macOS 26 device myself. I ran it multiple times with no failures, where the original test (without the changes) did fail consistently. LGTM.
-------------
Marked as reviewed by dnguyen (Committer).
PR Review: https://git.openjdk.org/jdk/pull/26833#pullrequestreview-3138440025
More information about the client-libs-dev
mailing list