RFR: 8159055: Clarify handling of null and invalid image data for ImageIcon constructors and setImage method [v25]

Phil Race prr at openjdk.org
Thu Aug 21 20:44:01 UTC 2025


On Tue, 5 Aug 2025 11:28:02 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   class javadoc modification
>
> test/jdk/javax/swing/ImageIcon/ImageIconTest.java line 90:
> 
>> 88:                        case IMAGE :
>> 89:                            if (v == ArgVal.NULL) {
>> 90:                                new ImageIcon((Image)null);
> 
> Suggestion:
> 
>                                new ImageIcon((Image) null);
> 
> I guess you advocated for having a space between the type cast operator and its argument.

Personally, I do not like having a space there.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25767#discussion_r2292086290


More information about the client-libs-dev mailing list